Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools_scm to set version #2813

Open
ZedThree opened this issue Nov 17, 2023 · 1 comment
Open

Use setuptools_scm to set version #2813

ZedThree opened this issue Nov 17, 2023 · 1 comment

Comments

@ZedThree
Copy link
Member

I'd really really like to completely remove all the hardcoded version numbers throughout the project. I discovered recently that you can run setuptools_scm from the command line, so we could run that in CMake (and chop of the bits CMake doesn't like).

We'd want a fallback if setuptools_scm isn't present, but that could be from a file that setuptools_scm generates -- we could do that in CI.

@dschwoerer
Copy link
Contributor

The issue with setuptools_scm is, it does not work on the master branch. It always bumps the patch level, and there is now way around that. That is the reason we did not adopt it so far.

While we are at it, it would be nice to print the full version when running BOUT++.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants