Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWMA vs mean unit of measure inconsistency in meters #74

Open
vladaionescu opened this issue Nov 20, 2013 · 2 comments
Open

EWMA vs mean unit of measure inconsistency in meters #74

vladaionescu opened this issue Nov 20, 2013 · 2 comments

Comments

@vladaionescu
Copy link

Meters can be used for a number of things, but consider this example:
We want to measure the number of events per second, where an event is folsom_metrics:notify(Name, 1).

So we do folsom_metrics:get_metric_value(Name). What we get in response is

[{count,...}, {one, ...}, {five, ...}, {fifteen, ...}, {day, ...}, {mean, ...}, {acceleration, ...}]

where one, five, fifteen and day are measured in events per second, but mean is measured in events per _micro_ second. Furthermore, acceleration is measured in events per second squared.

I believe it would be more consistent if mean were measured in events per second as well.

Suggested fix: divide this value by 1000000. May need to do something similar for meter reader as well.

@joewilliams
Copy link
Contributor

I would entertain a PR for this, please submit one with tests and I'll review.

@joewilliams
Copy link
Contributor

Folsom has moved, please resubmit your issue at https://github.com/folsom-project Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants