fix release.toml version check #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a mistake in bottlerocket-os#112 commit 67ef875. The check to make sure the version Release.toml matched the release version in Twoliter.toml could never succeed due to quotation marks around the version string. This fixes it and adds a test to prove that it works.
bcressey
approved these changes
Dec 8, 2023
cbgbt
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #112
Description of changes:
We had a mistake in #112 commit 67ef875. The check to make sure the version Release.toml matched the release version in Twoliter.toml could never succeed due to quotation marks around the version string.
This fixes it and adds a test to prove that it works.
Testing done:
Added tests that prove correctness.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.