Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating symlinks in sources/ does not trigger rebuild #422

Closed
mikn opened this issue Dec 21, 2024 · 2 comments · Fixed by bottlerocket-os/bottlerocket-settings-sdk#71
Closed

Comments

@mikn
Copy link

mikn commented Dec 21, 2024

Maybe this is well-known, but I just hit a snag with adding some new defaults to my variant (similar to how you manage your defaults in the core bottlerocket repository) and symlinked it from the defaults folder to the variant defaults.d folder, this did not get picked up by the build system that thought nothing had changed.

Maybe an easy fix? Maybe incredibly difficult? But now you know. :)

@cbgbt
Copy link
Contributor

cbgbt commented Dec 31, 2024

I think this should be an easy fix. The process which walks through defaults.d directories is invoked via a Cargo "build script" and lives here.

Seems like we emit a cargo:rerun-if-changed for each input file, but not the directory itself. Per the cargo docs we could emit the directory name for cargo to check every file underneath that directory.

@cbgbt
Copy link
Contributor

cbgbt commented Jan 3, 2025

A new tag bottlerocket-defaults-helper-v0.1.1 has been pushed to the bottlerocket-settings-sdk which should resolve this issue. You'll need to consume that as an update to the defaults-helper in your settings defaults package.

Please let us know if you still have issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants