Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twoliter: add kit overrides for test interactions #339

Closed

Conversation

jmt-lab
Copy link
Contributor

@jmt-lab jmt-lab commented Jul 29, 2024

Issue number: 331

Closes #331

Description of changes:

Adds a kit override option for testing and development use. Twoliter now accepts a variable --kit-override or -K where you can provide =. Twoliter will then look for a successfull build in that path to use the oci archive in-place of a kit in ECR. This does bypass Twoliter.lock though

Testing done:

  • Built bottlerocket core kit at /bottlerocket-core-kit
  • Bypassed twoliter update and built a variant using the built core kit via:
twoliter fetch --arch=x86_64 -K bottlerocket-core-kit=../bottlerocket-core-kit
twoliter build variant aws-ecs-2 --arch=x86_64

Verified it used the ../bottlerocket-core-kit/build/kits/bottlerocket-core-kit/bottlerocket-core-kit-....-x86_64.tar OCI archive

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jmt-lab jmt-lab requested review from cbgbt and sam-berning July 29, 2024 20:41
@jmt-lab jmt-lab self-assigned this Jul 29, 2024
@jmt-lab jmt-lab force-pushed the twoliter/kit-overrides branch from 3a28820 to aa06719 Compare July 29, 2024 21:25
@jmt-lab jmt-lab force-pushed the twoliter/kit-overrides branch from aa06719 to e614ed7 Compare July 29, 2024 22:55
@jmt-lab jmt-lab closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twoliter: kit override location for testing iteration purposes
1 participant