From 8d457434c670568403f317b6b9aa02a808b5c10a Mon Sep 17 00:00:00 2001 From: Ben Cressey Date: Sat, 21 Sep 2024 17:47:24 +0000 Subject: [PATCH] buildsys: mark erofs feature as experimental erofs is a relatively new filesystem, especially when compared with ext4. It shows promising results in terms of improved boot times, but its behavior at runtime on fully loaded nodes is more difficult to predict. Mark the image feature as experimental for now. This allows it to be enabled by downstream variants to facilitate additional experiments, without immediately endorsing it for production use. Signed-off-by: Ben Cressey --- tools/buildsys/src/manifest.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/buildsys/src/manifest.rs b/tools/buildsys/src/manifest.rs index 259c1a74..e68af3de 100644 --- a/tools/buildsys/src/manifest.rs +++ b/tools/buildsys/src/manifest.rs @@ -498,6 +498,11 @@ impl ManifestInfo { } } } + for experiment in EXPERIMENTAL_IMAGE_FEATURES { + if features.contains(experiment) { + println!("cargo:warning=Image feature {experiment} is experimental; use at your own risk!"); + } + } Some(features) } @@ -797,6 +802,8 @@ pub enum ImageFeature { HostContainers, } +const EXPERIMENTAL_IMAGE_FEATURES: [&ImageFeature; 1] = [&ImageFeature::ErofsRootPartition]; + impl TryFrom for ImageFeature { type Error = Error; fn try_from(s: String) -> Result {