Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customization of service annotations in Helm values #566

Open
cbgbt opened this issue Oct 11, 2023 · 0 comments
Open

Allow customization of service annotations in Helm values #566

cbgbt opened this issue Oct 11, 2023 · 0 comments
Labels
component/controller good first issue Good for newcomers type/enhancement

Comments

@cbgbt
Copy link
Contributor

cbgbt commented Oct 11, 2023

Image I'm using:
Brupop v1.3.0

Issue or Feature Request:
Currently, the controller service always applies prometheus.io annotations to enable metric scraping.

I've noticed that other charts tend to make this more configurable. We should allow complete customization of the annotations applied to the service (thanks for the suggestion in #559 (comment) @dani-CO-CN!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/controller good first issue Good for newcomers type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbgbt