Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove update time window #393

Open
gthao313 opened this issue Jan 24, 2023 · 3 comments
Open

remove update time window #393

gthao313 opened this issue Jan 24, 2023 · 3 comments

Comments

@gthao313
Copy link
Member

We improve time window to use cron expressions, but currently we still support update time window. In future, we need deprecate update time window.

@stmcginnis
Copy link
Contributor

I believe we are deprecating cron expressions in #351, right?

We actually need to track removal of the deprecated functionality after the deprecation period is over. We don't explicitly state a deprecation policy, so it might be good to clarify that somewhere so it's clear how long the functionality will remain deprecated before its removal.

@gthao313
Copy link
Member Author

emm, Actually no. Currently brupop uses update time window. For being more flexible to schedule maintenance time window on users' purpose, we think Cron expression would be a better choice to enhance time window scheduler. So #351 is to implement new feature cron expression scheduler. However, we should consider the "backward compatibility", so we will still support update time window on next release, and then we will deprecate update time window this feature. Related issue: #343

so it might be good to clarify that somewhere so it's clear how long the functionality will remain deprecated before its removal.

This makes sense. I think we still support update time window settings for one more version 1.1.0, and we still deprecate it then.

@stmcginnis
Copy link
Contributor

Deprecate means to communicate that the feature is no longer being actively supported and is planned to go away. That is the case with #351. Deprecate does not mean to remove. That is what happens after the deprecation period is over. It is no longer deprecated at that point - it is removed.

So right now, this is deprecated. Later on we plan to remove.

@gthao313 gthao313 changed the title deprecate update time window remove update time window Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants