New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testsys-launcher: CFN parameter for instance type that is launched #827

Open

jpmcb opened this issue May 16, 2023 · 0 comments

Contributor

jpmcb commented May 16, 2023

It'd be great to provide a CFN parameter for the type of instance that is launched in the nodegroup:

testsysNodegroupInstanceType := awscdk.NewCfnParameter(stack, jsii.String("TestsysNodegroupInstanceType"), &awscdk.CfnParameterProps{
	Type:        jsii.String("String"),
	Description: jsii.String("The x86 instance type to launch in the nodegroup"),
	Default:     jsii.String("m5.xlarge"),
})

But this is currently blocked on aws/aws-cdk#25615

We could drop in a env variable at "synth-time" to get it in but it'd be great if there was just a single interface to drop these in

jpmcb added the blocked label

rpkelly removed the blocked label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment