Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the amazon-ecs-cni-plugins package Version #249

Closed
ginglis13 opened this issue Nov 7, 2024 · 0 comments · Fixed by #277
Closed

Normalize the amazon-ecs-cni-plugins package Version #249

ginglis13 opened this issue Nov 7, 2024 · 0 comments · Fixed by #277
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@ginglis13
Copy link
Contributor

ginglis13 commented Nov 7, 2024

What I'd like:

The amazon-ecs-cni-plugins package uses a git rev as Version in its spec:

%global ecscni_gitrev 53a8481891251e66e35847554d52a13fc7c4fd03
Name: %{_cross_os}amazon-ecs-cni-plugins
Version: %{ecscni_gitrev}

With changes to application inventory generation in bottlerocket-os/twoliter#384, packages ideally will use a more easily comparable versioning.

Use https://github.com/aws/amazon-ecs-cni-plugins/blob/master/VERSION for the package's version (which is 2024.09.0 as of writing)

Bump its Epoch to 1 along with this change.

@ginglis13 ginglis13 added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant