Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key management functionality #599

Closed
wants to merge 0 commits into from
Closed

Add key management functionality #599

wants to merge 0 commits into from

Conversation

samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Aug 27, 2020

This PR adds key management features of:

  1. Password changing (Fixes Change password #303)

  2. The ability to move the key from VortaKeyringDB to secure storage

  3. Key import/export. (Fixes Import / path to repo keyfile #304, fixes Import / path to repo keyfile #803)

This issue I'm having is the input for 'borg key import --paper' happens in interactive console mode.
I would like to know if there is a way to take interactive console input into Qt, as I want to implement it without having to take parts of borg code.
My alternate solution is to remove paper key backup support.

Edit: Going to merge all the options into one tab. This also uses code from #550

Picture of UI:
v1
v2
v3

@ThomasWaldmann
Copy link
Collaborator

Commenting on:

This issue I'm having is the input for 'borg key import --paper'
happens in interactive console mode.

I would like to know if there is a way to take interactive console input
into Qt, as I want to implement it without having to take parts of borg code.

My alternate solution is to remove paper key backup support.

I'ld suggest doing this PR without key restore capability for paper key hexdump data.

You could try adding that in a later PR (maybe after doing some ground work in borg to make it easier).

@samuel-w
Copy link
Contributor Author

samuel-w commented Sep 5, 2020

Closing to avoid running tests whenever I push. Will reopen later.

@samuel-w
Copy link
Contributor Author

Marking the paper backup for later, the rest is fine.

@samuel-w samuel-w reopened this Feb 18, 2021
@samuel-w samuel-w marked this pull request as ready for review February 18, 2021 06:09
@samuel-w samuel-w closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change password Import / path to repo keyfile
2 participants