Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed label and tooltip for startup of Vorta #1804

Merged
merged 5 commits into from
Sep 9, 2023

Conversation

SAMAD101
Copy link
Collaborator

@SAMAD101 SAMAD101 commented Sep 3, 2023

Description

For Issue #1763

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have read the CONTRIBUTING guide.
  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I added two comments how the wording can be improved even further.

src/vorta/store/settings.py Outdated Show resolved Hide resolved
src/vorta/store/settings.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

I removed the commit adding peewee to the requirements file by running the following commands:

git rebase 6abd0f5862140273c6c1a23c33c288f13529f924 --onto=master
git push --force-with-lease

@real-yfprojects real-yfprojects merged commit 7d2b363 into borgbase:master Sep 9, 2023
11 checks passed
@SAMAD101 SAMAD101 deleted the issue1763 branch September 9, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants