Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent in-line archive rename during ongoing operation #1791

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

bigtedde
Copy link
Collaborator

Description

Fixes #1790

Motivation and Context

Improved stability during background operations.

How Has This Been Tested?

I edited the current archive rename unit test to ensure it asserts the rename button is enabled before attempting the rename.
Passes tests locally and on GitHub workflow.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@bigtedde
Copy link
Collaborator Author

bigtedde commented Sep 5, 2023

I have tested this locally, and it works to remove the ability for users to rename archives during a background operation. This improves stability of the archive table, and prevents visual bugs that occur when a rename is done during another operation.

@m3nu m3nu merged commit 4350f78 into borgbase:master Sep 11, 2023
11 checks passed
@m3nu
Copy link
Contributor

m3nu commented Sep 11, 2023

Thanks for taking care, @bigtedde !

@bigtedde bigtedde deleted the rename branch September 15, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-line rename allowed during other operations
3 participants