DEV - Code: Relative imports.

[real-yfprojects]

I was looking at the code of vorta and noticed that absolute imports instead of relative imports are used for importing other modules of the vorta package. Is there a reason for that?
I could create a PR converting all the package-internal imports to relative ones.

Example 1

vorta/src/vorta/__main__.py

Line 12 in eadb3e7

from vorta.utils import parse_args

would be changed to

from .utils import parse_args

Example 2

vorta/src/vorta/borg/check.py

Line 1 in eadb3e7

from .borg_job import BorgJob

Already in place 🤷

Example 3

vorta/src/vorta/borg/prune.py

Line 2 in eadb3e7

from vorta.utils import format_archive_name

would be converted to

from ..utils import format_archive_name

[m3nu]

I intentionally use absolute imports unless it's the same package. This is also what's suggested in theofficial docs.

Absolute imports are recommended, as they are usually more readable...

I also find absolute imports easier to find and update, if a package is renamed.

Still appreciate the effort and concern to improve something, but changing vorta.utils to ..utils might get us into bike-shedding territory. 😬

We have more urgent issues open. Especially those marked Good first issue are there to get started and get to know the code.

Thanks and happy new year!

[real-yfprojects]

I agree. After setting up borg and vorta I might have the time to look at one of the good first issues.
Happy new year to you too!