Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg2: msgpack.Unpacker buffer size #8440

Open
ThomasWaldmann opened this issue Oct 1, 2024 · 1 comment
Open

borg2: msgpack.Unpacker buffer size #8440

ThomasWaldmann opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@ThomasWaldmann
Copy link
Member

as borg now uses repository.store_load and .store_save to load and save the chunks index, we need a rather high limit here.

a quick fix is to set this to ~4GiB (the maximum).

the real fix might be using chunks of the data (preferably <= MAX_OBJECT_SIZE), so there is less to unpack at once.

Traceback (most recent call last):
  File "borg/archiver/_common.py", line 176, in wrapper
  File "borg/archiver/create_cmd.py", line 268, in do_create
  File "borg/archiver/create_cmd.py", line 169, in create_inner
  File "borg/archiver/create_cmd.py", line 527, in _rec_walk
  File "borg/archiver/create_cmd.py", line 527, in _rec_walk
  File "borg/archiver/create_cmd.py", line 467, in _rec_walk
  File "borg/archiver/create_cmd.py", line 284, in _process_any
  File "borg/archive.py", line 1381, in process_file
  File "borg/archive.py", line 1142, in process_file_chunks
  File "borg/archive.py", line 1132, in chunk_processor
  File "borg/cache.py", line 754, in add_chunk
  File "borg/cache.py", line 720, in seen_chunk
  File "borg/cache.py", line 716, in chunks
  File "borg/cache.py", line 667, in build_chunkindex_from_repo
  File "borg/remote.py", line 539, in do_rpc
  File "borg/remote.py", line 779, in call
  File "borg/remote.py", line 898, in call_many
  File "msgpack/_unpacker.pyx", line 399, in msgpack._cmsgpack.Unpacker.feed
  File "msgpack/_unpacker.pyx", line 422, in msgpack._cmsgpack.Unpacker.append_buffer
msgpack.exceptions.BufferFull
@ThomasWaldmann
Copy link
Member Author

#8439 has a workaround good for index sizes up to 4GB.

@ThomasWaldmann ThomasWaldmann modified the milestones: 2.0.0b12, 2.0.0rc1 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant