-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for modular build structure. #850
Conversation
…a source in install targets.
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #850 +/- ##
===========================================
- Coverage 99.21% 98.54% -0.67%
===========================================
Files 157 157
Lines 8421 8407 -14
===========================================
- Hits 8355 8285 -70
- Misses 66 122 +56 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
Please review and merge this PR at your earliest convenience. |
Nevermind. I managed to do it in #860. |
@@ -52,7 +51,6 @@ local SOURCES = | |||
segments_encoded_view.cpp | |||
segments_ref.cpp | |||
segments_view.cpp | |||
snippets.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a merge misstep at some point in the past months.
@@ -64,7 +62,6 @@ local SOURCES = | |||
grammar/alnum_chars.cpp | |||
grammar/alpha_chars.cpp | |||
grammar/charset.cpp | |||
grammar/ci_string.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.. Probably a merge misstep at some point in the past months.
Doing a squash merge would have been easier. |
Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html |
An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html |
GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html |
Rebased and merged as 471aec5 |
This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.
This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:
This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.