Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From version 1.70 and onwards, .7z archvies no longer use Windows line endings #32

Open
SigmundVik opened this issue Feb 24, 2022 · 1 comment

Comments

@SigmundVik
Copy link

The documentation states:
"Distribution files with extensions .zip and .7z use Windows line endings."

Starting with version 1.70, this is no longer the case. Either the documentation should get updated to reflect this change, or the line endings in the .7z (and .zip) archives should follow the documentation.

(I would prefer the latter, since I can then choose what line endings I want based on which archive I download.)

@sdarwin
Copy link
Contributor

sdarwin commented Feb 24, 2022

Investigating the history of the bug.
March 4, 2019: boostorg/boost@2887df3 Before the commit these scripts were run:

    - exec "${HOME}/script.sh" test_pre:
    - exec "${HOME}/script.sh" test_override:
    - exec "${HOME}/script.sh" test_post:

After the commit, one script executes:

ci_boost_release.py test_override

test_pre should probably be reinstated. Include in https://github.com/boostorg/boost/blob/master/.circleci/config.yml

     - run: '[ "$CIRCLE_NODE_INDEX" != "0" ] || EOL=LF python3 ${HOME}/ci_boost_release.py test_pre'
     - run: '[ "$CIRCLE_NODE_INDEX" != "1" ] || EOL=CRLF python3 ${HOME}/ci_boost_release.py test_pre'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants