Improves reconnection responsiveness #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VemundH I can't reproduce you problems locally so you might want to test this before I merge it. |
|
Made you back an admin. |
mzimbres
force-pushed
the
205-it-takes-a-long-time-to-detect-connection-lost
branch
from
b190a5f
to
f1136e3
Compare
mzimbres
force-pushed
the
205-it-takes-a-long-time-to-detect-connection-lost
branch
from
f1136e3
to
4cfe146
Compare
As the user points out in #205 wait_for_all might be the cause of delay in the reconnection. I could not observe any improvement in my local setup but wait_for_one_error look the correct token and all tests pass so I am willing to change it.
mzimbres
force-pushed
the
205-it-takes-a-long-time-to-detect-connection-lost
branch
from
4cfe146
to
e9c8ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the user points out in
wait_for_allmight be the cause of delay in the reconnection. I could not observe any improvement in my local setup butwait_for_one_errorlook the correct token and all tests pass so I am willing to change it.