Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test streams should use fail_count #46

Closed
vinniefalco opened this issue Jan 19, 2023 · 1 comment
Closed

Test streams should use fail_count #46

vinniefalco opened this issue Jan 19, 2023 · 1 comment

Comments

@vinniefalco
Copy link
Member

One of the main test modes of test::stream is that it can fail on the Nth operation, for increasing values of N. This ensures that every possible branch in the code being tested is exercised:

https://github.com/boostorg/beast/blob/97ece405b8127e1d4767a8f63b82478d5637b9ec/include/boost/beast/_experimental/test/fail_count.hpp#L31

The tests should be constructing the test::stream with a fail_count, and then running the same test over and over again in a loop with incrementing fail_count until the test passes.

@mzimbres
Copy link
Collaborator

mzimbres commented Sep 2, 2023

PR #151 has removed the resp3::read and async_read functions and therefore we don't need the beast test stream anymore. The way the parser works now enables testing without any concept of stream.

@mzimbres mzimbres closed this as completed Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants