Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min/max macro warning or make it optional #10

Open
HDembinski opened this issue Aug 22, 2019 · 0 comments
Open

Remove min/max macro warning or make it optional #10

HDembinski opened this issue Aug 22, 2019 · 0 comments

Comments

@HDembinski
Copy link

The max/min macro issue does not seem to be relevant anymore in modern compilers. I was completely unaware of this in Boost.Histogram and the code works fine on all msvc versions which support C++14. I added the patches to Histogram to get rid of this warning, but now my code became a lot less readable. I am considering to revert this change and propose instead to remove the min/max macro check from the inspection list.

Another solution would be to blacklist checks individually for each library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant