You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The max/min macro issue does not seem to be relevant anymore in modern compilers. I was completely unaware of this in Boost.Histogram and the code works fine on all msvc versions which support C++14. I added the patches to Histogram to get rid of this warning, but now my code became a lot less readable. I am considering to revert this change and propose instead to remove the min/max macro check from the inspection list.
Another solution would be to blacklist checks individually for each library.
The text was updated successfully, but these errors were encountered:
The max/min macro issue does not seem to be relevant anymore in modern compilers. I was completely unaware of this in Boost.Histogram and the code works fine on all msvc versions which support C++14. I added the patches to Histogram to get rid of this warning, but now my code became a lot less readable. I am considering to revert this change and propose instead to remove the min/max macro check from the inspection list.
Another solution would be to blacklist checks individually for each library.
The text was updated successfully, but these errors were encountered: