Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding histogram equalization and histogram matching #442

Closed
wants to merge 1 commit into from

Conversation

NEDJIMAbelgacem
Copy link

@NEDJIMAbelgacem NEDJIMAbelgacem commented Mar 5, 2020

Description

  • Histogram equalization implementation.
  • Histogram matching (specification) implementation.
  • Histogram visualisation as .jpg image.

This is part of my competency test solution for GSoC 2020 and I would be happy to improve it according to feedback.

References

https://en.wikipedia.org/wiki/Histogram_equalization
https://en.wikipedia.org/wiki/Histogram_matching
The great book https://link.springer.com/book/10.1007/978-1-84800-191-6
Thank you for recommending the book it is very good.

Tasklist

  • Add test case(s)
  • Make a better generic implementation
  • Downscale histogram visualization image.
  • Ensure all CI builds pass
  • Review and approve

@mloskot
Copy link
Member

mloskot commented Mar 5, 2020

Is this by any chance related to GSoC 2020?

@NEDJIMAbelgacem
Copy link
Author

@mloskot Yes it is, sorry I forgot to mention that in the description.

@mloskot
Copy link
Member

mloskot commented Mar 5, 2020

If this is your solution for the competency test, then please also read https://www.boost.org/community/gsoc.html

@NEDJIMAbelgacem
Copy link
Author

Yes, I already got through GSoC page and all. Can you please clarify what I misunderstood ?

@NEDJIMAbelgacem NEDJIMAbelgacem changed the title Added histogram equalization and histogram matching [WIP] Adding histogram equalization and histogram matching Mar 5, 2020
@mloskot
Copy link
Member

mloskot commented Mar 5, 2020

If this PR is related to GSoC and the competency test, it would be helpful if the description states that, for example, see #435.

As we already have received similar PRs, i.e. GSoC and competency tests, please find them and read through the comments to see what to expect w.r.t. to your PR For example, see #435 (comment) and #430

@mloskot mloskot added status/work-in-progress Do NOT merge yet until this label has been removed! google-summer-of-code All items related to GSoC activities labels Mar 10, 2020
@mloskot
Copy link
Member

mloskot commented Jan 25, 2021

Thanks once again for your efforts, but this functionality has been developed as part of the [gsoc2020] Histogram Computation and Algorithms project.

You are more than welcome to help us improve the histogram support.

@mloskot mloskot closed this Jan 25, 2021
@mloskot mloskot removed the status/work-in-progress Do NOT merge yet until this label has been removed! label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
google-summer-of-code All items related to GSoC activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants