Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail identifiers in public APIs could say __implementation_defined__ #113

Open
vinniefalco opened this issue Nov 2, 2021 · 2 comments

Comments

@vinniefalco
Copy link
Member

For example here

template<class CharSet>
detail::pct_encoded_bnf<CharSet>
pct_encoded_bnf(
    CharSet const& cs,
    pct_encoded_str& t) noexcept;

Currently the workaround is to write

template<class CharSet>
#ifdef BOOST_URL_DOCS
__implementation_defined__
#else
detail::pct_encoded_bnf<CharSet>
#endif
pct_encoded_bnf(
    CharSet const& cs,
    pct_encoded_str& t) noexcept;
@evanlenz
Copy link
Contributor

Are there any existing examples of this workaround in the URL library? (I'm not finding any.) That's fine if not, but if we do have existing examples, they would serve as good test cases for me.

@vinniefalco
Copy link
Member Author

I didn't like public functions returning types that were private so I refactored Boost.URL to not do this. We can put a hold on this issue until it comes up again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants