Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not set CMAKE_MODULE_PATH. #874

Open
qis opened this issue Jun 19, 2022 · 0 comments
Open

Please do not set CMAKE_MODULE_PATH. #874

qis opened this issue Jun 19, 2022 · 0 comments

Comments

@qis
Copy link

qis commented Jun 19, 2022

https://github.com/boostorg/compute/blob/36350b7/CMakeLists.txt#L64 sets CMAKE_MODULE_PATH and overwrites CMake and possibly toolchain and Compiler/Platform settings.

This prevents users from providing find_package scripts or configs that use include(... relative to the default or toolchain CMAKE_MODULE_PATH.

Please replace it with

list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")

like the hof library does, or

list(INSERT CMAKE_MODULE_PATH 0 ${CMAKE_BINARY_DIR}/cmake)

like the gil does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant