Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfinished task is resumed after co_main returns #198

Open
nyibbang opened this issue Sep 11, 2024 · 0 comments
Open

Unfinished task is resumed after co_main returns #198

nyibbang opened this issue Sep 11, 2024 · 0 comments

Comments

@nyibbang
Copy link
Contributor

Hello,

I've been using Cobalt with Boost 1.86.0, and I've had an issue with my code that caused it to segfault due to use of destroyed resources.

I've reproduced my issue on a smaller sample code:

#include <boost/asio/error.hpp>
#include <boost/cobalt.hpp>
#include <boost/asio.hpp>
#include <boost/system/system_error.hpp>
#include <iostream>

namespace cobalt = boost::cobalt;
namespace asio = boost::asio;
using namespace std::chrono_literals;

int GLOBAL_FLAG = 0;

struct set_global_flag {
    set_global_flag() {
        GLOBAL_FLAG = 1;
    }

    ~set_global_flag() {
        GLOBAL_FLAG = 0;
    }
};

cobalt::task<void> long_loop_task() {
    auto exec = co_await cobalt::this_coro::executor;

    auto timer = cobalt::use_op.as_default_on(asio::steady_timer(exec));
    while (!co_await cobalt::this_coro::cancelled) {
        std::cout << "long_loop: flag is " << GLOBAL_FLAG << std::endl;
        try {
            timer.expires_from_now(1s);
            co_await timer.async_wait();
        }
        catch (const boost::system::system_error& err) {
            if (err.code() == asio::error::operation_aborted) {
                std::cout << "long_loop: operation aborted" << std::endl;
            }
        }
    }
}

cobalt::main co_main(int, char**) {
    auto sgf = set_global_flag();
    auto llt = long_loop_task();

    auto exec = co_await cobalt::this_coro::executor;
    auto timeout_timer = cobalt::use_op.as_default_on(asio::steady_timer(exec));
    timeout_timer.expires_from_now(50ms);

    co_await cobalt::race(
        llt,
        timeout_timer.async_wait()
    );
    co_return 0;
}

I build this code with g++13 & libstdc++ on Ubuntu 22.04.

The output of this program is the following:

long_loop: flag is 1
long_loop: flag is 0
long_loop: flag is 0
long_loop: flag is 0
long_loop: flag is 0
[...]

As we can see, the loop accesses the global flag after the set_global_flag object is destroyed (the flag is reset to 0), which means that the long_loop_task coroutine has been resumed after the co_main function returned. In this program, nothing much happens, but in my original code, the flag was a pointer passed by reference to the loop and the set_global_flag was a unique_ptr, which caused the loop to access through the reference an object that was destroyed.

The program never terminates, even if an interrupt (Ctrl+C) or termination (SIGTERM) signal is sent. I have to kill it with a SIGKILL or SIGQUIT.

I understand that according to cobalt::race specification, the loop task should not be cancelled, because it is passed by lvalue-reference. It is however surprising to me that it is resumed though, even after the task object was destroyed.

Am I missing something ?
Thank you in advance.

@klemens-morgenstern klemens-morgenstern added bug Something isn't working and removed bug Something isn't working labels Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants