-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] 지도 그라디언트 #348
Merged
Merged
[iOS] 지도 그라디언트 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static 변수를 사용하는 방식에서 FileManager를 사용하는 방식으로 리팩토링
여러 곳에 파편화되어 있던 여정 시작 / 중단 / 재개 로직을 Home 부분에 통합
Closed
1 task
PushedGun
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정해주신 내용 잘 보았습니다.
CAGradientLayer을 extension하여 사용하는 방식도 괜찮았을 것 같아요.
고생하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 배경
🔧 작업 내역
📝 리뷰 노트
MSGradientLayer
기존 CAGradientLayer는
colors
를CGColor
를 사용합니다.때문에
UIColor
를 사용할 수 있는 간단한 커스텀 클래스를 만들어줬습니다.📸 스크린샷