Include the users' specialism field in cohort response bodies #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run tests when making a pull request.
…e for the user. For example the values such as profile.firstName.
…team3 into 9-backend-design-cohort-update-prisma-and-api-spec
…team3 into 32-update-prisma-to-represent-the-api-spec
…team3 into Setting-up-Automated-testing-Backend-25
Updated openapi.yml to include API endpoints for comments
…team3 into 9-backend-design-cohort-update-prisma-and-api-spec
…the-api-spec updated prisma to work in accordance to the api spec
…ackend-25 Targeting the correct main now
…-prisma-and-api-spec Update Cohort Prisma model and API spec
…team3 into 1-api-endpoint-get-get-all-posts
GET endpoints for posts
coverage tool should now work. Had to switch from nyc to c8.
…team3 into 33-change-response-data-in-cohort
…ss from firstname -> firstName
…k/team-dev-server-ex-2410-team3 into 37-fix-json-format-bug
37 fix json format bug
Change response data in cohort
…ialism # Conflicts: # src/routes/user.js
Update user and Profile
…team3 into 46-populate-database-with-connecting-cohort-with-user
…ecting-cohort-with-user Update Prisma seeding to populate database with connecting cohort with user
…s' response bodies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have now added to include the "specialism" field of the users in the cohort endpoint response bodies. For example GET /cohorts/1 returns:
{ "status": "success", "data": { "cohort": { "id": 1, "name": "Web Development 122222", "startDate": "2000-11-01T00:00:00.000Z", "endDate": "2001-12-01T00:00:00.000Z", "createdAt": "2024-10-31T11:18:59.541Z", "updatedAt": "2024-10-31T12:11:29.290Z", "users": [ { "id": 1, "role": "STUDENT", "email": "[email protected]", "specialism": "Software Developer", "profile": { "firstName": "Joe", "lastName": "Bloggs", "bio": "Hello, world!", "githubUsername": "" } } ] } } }Note that the "specialism" field is included.