-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing books from another Bookwyrm instance fails #3004
Comments
Outside of a Dog is on 0.6.3 if that is significant. |
In the Outside of a Dog Imports page, the import is listed as:
Yet on the Celery Status page, there are no pending tasks of any kind. In the bookwyrm-worker logs, this error message around the time seems relevant:
There's no mention of reviews or ratings. Maybe the presence of a review/rating messes with the column sequence and leads the Published Date to appear null? |
From the error, it sounds like the issue is that it isn't correctly assigning a date to the status that is created when it finds a review or rating |
Here's the whole log for that import:
After this error, the task disappears from celery but is still listed as Pending in the Imports screen. |
I can replicate this. Problem number 1 is because the BookWyrm CSV export doesn't include any dates at all - which is not optimal to say the least. In published_date_guess = item.date_read or item.date_added This eventually causes an exception because both values are Problem number 2 happens because we also don't include any shelf or readthrough information in the export. This means there is nothing to connect these books to your shelves. In fairness to BookWyrm, "BookWyrm" is not actually a listed import source in the imports page. But in fairness to @eldang, it seems reasonable that one might be able to successfully import a CSV exported from the same application! Regardless of the work we've nearly completed with #3054 (previously #2980) I think we still should offer a simple CSV import/export for books and reviews. I'll take a look at this today. |
I tried to move my bookwyrm account across instances. I resorted to a csv book export of the books in the old instances as @eldang did. Then, I imported the CSV into the new istance using the goodread option. So I cheated. I took a look at the I guess I could have done something similar adding a Is this enough to have a "simple CSV import/export for books"? I am afraid there is more involved in importing a book than what I could grasp. Nonetheless, I feel such feature is useful. Despite the huge work in #3054 a user does not always have the chance to use the User Account import/export flow. |
Describe the bug
I'm running into a pair of issues importing a CSV exported from Bookwyrm: rows with a review or rating fail, and the books that get successfully imported don't seem to get added to my books.
To Reproduce
Steps to reproduce the behavior:
Other things I've tried:
Expected behavior
The books import with reviews, and get shelved the same as in the source instance.
Instance
outside.ofa.dog
Additional context
I am aware that #2980 may make this issue redundant by providing an alternative way to migrate books between instances. I can't tell how close that work is to completion, which should probably determine whether this bug is worth working on in parallel or not.
Desktop (please complete the following information):
- OS: Mac OS 13.5.2
- Browser Firefox
- Version 117.0.1
The text was updated successfully, but these errors were encountered: