Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata update handling #634

Open
phirestalker opened this issue Sep 4, 2024 · 4 comments
Open

Metadata update handling #634

phirestalker opened this issue Sep 4, 2024 · 4 comments

Comments

@phirestalker
Copy link

Right now some shows are not updated if the updates include watched seasons. I realize that you are working on this for the 1.0 update. The short description of the fix sounds like it may still leave out some updates by only updating the new unwatched seasons.

I have a few questions about the data available from TMDB and the handling of show metadata update (i.e. season and episode number changes)

  1. Does TMDB have episode IDs as well as show IDs?
  2. If not, do they at least have absolute episode numbers?
  3. If they have either of those available, wouldn't it be possible to update the metadata and keep the watched status?

I guess if they do not have either of those things, I will need to make some suggestions. The amount of tomfoolery over which episodes are in what season over there is out of control (especially for some shows, notorious in fact).

@bonukai
Copy link
Owner

bonukai commented Sep 5, 2024

TMDB have episodes and seasons IDs, and in the new version they are used to detect change of episode numbers. Just like you suggest, if a season cannot be updated due to watched episodes (this usually happens, when two episodes are merged into one), then only this season is not updated. The show metadata, and other season are updated in this situation.

I am still open to suggestions :)

@phirestalker
Copy link
Author

I was just thinking that since the episodes have some way to uniquely identify them, other than their season and episode, seasons that are watched could still be updated or rearranged. Or, do you mean that the only time it can't be updated is when they merge episodes?

This brings up another question. How is it tracked when I watch an episode in Jellyfin? Is it by the episode id? When they change seasons (like after DVD releases) can subsequent watches get linked to the wrong episode?

Also, I want to clarify. You mean shows update unwatched seasons in the wip branch, but still not for the main branch right?

@bonukai
Copy link
Owner

bonukai commented Sep 5, 2024

I was just thinking that since the episodes have some way to uniquely identify them, other than their season and episode, seasons that are watched could still be updated or rearranged. Or, do you mean that the only time it can't be updated is when they merge episodes?

Season won't be updated if there is an episode in local database marked as seen or rated, but this episode has been removed from the TMDB. In this case only affected season is not updated.

If episodes have changed number, then they will be rearranged, even if they have been marked as seen, based on the episode TMDB id.

Also, I want to clarify. You mean shows update unwatched seasons in the wip branch, but still not for the main branch right?

Yes, this is only implemented in the wip branch.

This brings up another question. How is it tracked when I watch an episode in Jellyfin? Is it by the episode id? When they change seasons (like after DVD releases) can subsequent watches get linked to the wrong episode?

Jellyfin plugin only uses season and episode number to identify an episode in the MediaTracker

I have never came across situation, where season number would be rearranged, so this was not implemented. Do you have an example of a show, when this happen?

@phirestalker
Copy link
Author

I have an example of a show where it is likely to have or to happen. Futurama. They have changed the seasons from being 12 seasons to being only 9, so there must be some shuffling between seasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants