Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message when exporting svg from workflow #18

Open
cjsha opened this issue Dec 18, 2024 · 2 comments
Open

Add warning message when exporting svg from workflow #18

cjsha opened this issue Dec 18, 2024 · 2 comments

Comments

@cjsha
Copy link

cjsha commented Dec 18, 2024

When exporting SVGs, I think it could be helpful to have a warning message if a workflow does not compile or the environment doesn't contain all the necessary packages to run the workflow (which creates hatched nodes in the exported SVG).

@glopesdev
Copy link
Member

glopesdev commented Dec 18, 2024

@cjsha this is a good idea. I am wondering whether we should go further and actually fail the call with an error, since for such purposes the resulting export will most likely never be quite useful.

That way CI systems could more easily signal a failure in their pipelines.

@cjsha
Copy link
Author

cjsha commented Jan 2, 2025

Should it be an option to elevate from warning to error? I can imagine a situation in which you want to export an uncompilable workflow to discuss specific reasons why a workflow might not compile and how Bonsai behaves in those situations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants