-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Grouped spinners? #152
Comments
@cpreston321 that PR doesn't resolve this issue though. It just runs |
@JoshuaKGoldberg Got it, i reopened the issue. So if task 1 completes it moves to task 2.. Let's say if task 2 fails does that kick out of the task process / cancel the spinner ? Also if it easier you can create a draft pull request with some examples. I think for this functionality we can keep this at the |
I would think so, yeah. At least by default. Maybe there could be an API option for whether to bail or continue?
Yes! #158 is roughly what I was thinking of. I haven't put too much thought into the API design, pending posting here. |
Is your feature request related to a problem? Please describe.
Grouping (https://github.com/natemoo-re/clack/tree/24a3f4a20019c7dad2f69bcf163a8b5a3f747a16/packages/prompts#grouping) is available right now for prompts, but not for spinners. But I'd like to group the spinners together too: having a parent task and sub-task.
Describe the solution you'd like
Could we add a new spinner API analogous to
p.group
? Maybe,p.spinnerGroup
?Describe alternatives you've considered
In JoshuaKGoldberg/create-typescript-app#708 -> JoshuaKGoldberg/create-typescript-app#710 I kind of did it manually, wrapping around Clack. It's not great.
Screen.Recording.2023-08-26.at.2.17.08.PM.mov
Additional context
I'd be happy to contribute this, or if you don't want to keep it as a core feature, publish it as a standalone helper package.
The text was updated successfully, but these errors were encountered: