Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nullable/ommitempty fixes #275

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

oliver006
Copy link
Collaborator

Added a few fixes for #182

Looking for possible candidates to address some of the issues of #4

BoldBrandonM
BoldBrandonM previously approved these changes Mar 14, 2024
Copy link

@BoldBrandonM BoldBrandonM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but please make sure to very explicitly note this breaking change in the release notes, as it would be easy to miss that a client needs to update logic and not just typing to accommodate it.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97113cc) to head (0ec794a).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         2211      2211           
=========================================
  Hits          2211      2211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliver006 oliver006 merged commit bd8e345 into bold-commerce:master Mar 15, 2024
5 checks passed
@oliver006 oliver006 deleted the oh_some_nullables branch March 15, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants