Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE repository status 'Private' (OAM 'Deposited (Not live)') #172

Open
mrdsaunders opened this issue Jan 31, 2020 · 23 comments
Open

SE repository status 'Private' (OAM 'Deposited (Not live)') #172

mrdsaunders opened this issue Jan 31, 2020 · 23 comments

Comments

@mrdsaunders
Copy link
Collaborator

if there is a record_publication_date -> repository -status Public
else if there is a record_review_status -> repository-status Private (In review)
else -> repository-status Private

In OAM:
repository -status Public -> Live
repository-status Private (In review) -> In review
repository-status Private -> Deposited (Not live)

It would seem more accurate to crosswalk all records without a record_publication_date as 'In review' since they have been deposited but are not live. Does anyone know what the rationale was for AB to write the crosswalk the way he did originally?

@tomwrobel
Copy link
Collaborator

@mrdsaunders I think the rationale was that Oxris might want to know (or care) about the distinction between 'deposited (but otherwise untouched)' and 'reviewed (and therefore under embargo if not live)'

We can possibly re-create this logic for objects that have a reviewer action associated with them somewhere in their histories but aren't in the access db

@mrdsaunders
Copy link
Collaborator Author

Thanks Tom that's helpful. We can discuss at ORA-SE.

@mrdsaunders
Copy link
Collaborator Author

Depending on outcome, solution could be ORA side, crosswalk or both.

@eugeniobarrio
Copy link
Collaborator

Are those repository-status Private -> Deposited (Not live) ever going to be reviewed?

@tomwrobel
Copy link
Collaborator

@eugeniobarrio they're probably already reviewed, just that no review status was recorded in ORA3 that corresponds to record_review_status in ORA4. We can probably imply that for those. Otherwise, yes.

@mrdsaunders
Copy link
Collaborator Author

We could just as easily change the crosswalk to map has ORA record but no status to In Review instead of Deposited (Not live). Are there any problems anyone can foresee with that?

We can also have a discussion about whether we actually want a status of 'Deposited (Not touched yet)' and how whether we could get S Ltd to map that to a status that doesn't trigger reminders to deposit.

@mrdsaunders
Copy link
Collaborator Author

In the short term, can we do as you suggest Tom and imply a status for those currently with no status (in order that they show as 'In review' in SE)?

In the longer term, we could use this status to distinguish between Deposited (review not started) and Deposited (in review). This could in turn potentially be used to distinguish between embargo end of 31/12/9999 where it is genuinely indefinite vs temporarily entered pending review.

What are the current values for record_review_status?

@tomwrobel
Copy link
Collaborator

tomwrobel commented Feb 5, 2020

The short term request is being tracked here: https://trello.com/c/uhkJz0bq

@mrdsaunders the allowed values for Review status are contained within:

https://gitlab.bodleian.ox.ac.uk/ORA4/reviewinterface/blob/master/config/authorities/review_status.yml

If one is not set, which value would you like?

@jjpartridge @tobypitts I assume the value "Incomplete/In progress" would indicate that an item was under review but that we had no other information?

@tobypitts can I have some sample object UUIDs for testing?

@tobypitts
Copy link
Collaborator

tobypitts commented Feb 5, 2020

@tomwrobel Yes, we've generally been using the "Incomplete/In progress" value when we have begun a review but have not finished it or arrived at the point where we are able to assign another status

@tomwrobel I will gather some sample uuids shortly. Do you need a mix of Review status values?

@mrdsaunders
Copy link
Collaborator Author

Hi Tom. We don't mind what the value is as we don't interpret any specific values, just the existence of one. Use whatever value is appropriate to the the actual condition of the record.

@tomwrobel
Copy link
Collaborator

@jjpartridge are we happy with Incomplete/In progress?

@jjpartridge
Copy link
Collaborator

@tomwrobel @mrdsaunders can you confirm for me the scenario that we applying this value to?

has no record publication date
has no review status recorded

Is that it?

Didn't we create "Deposited (not reviewed)" for this purpose

How many objects do we have that do not have a record publication date and/or a review status? Surely it is only the new deposits that have not yet been reviewed...

@tomwrobel
Copy link
Collaborator

I think the issue is that lots of records did not have their record_review_status set, but they have been reviewed. New deposits in ORA4 are not a problem, because the deposited (not reviewed) status should be set for these records

@jjpartridge
Copy link
Collaborator

Those records will have record publication dates though - correct? And therefore set as 'Public'

@mrdsaunders
Copy link
Collaborator Author

@jjpartridge Corect, it is applied to :
has no record publication date
has no review status recorded

@mrdsaunders
Copy link
Collaborator Author

@jjpartridge If you filter OAM by status 'Deposited (not live)' you will see objects that are not recent deposits but which have neither record publication date nor record_review_status.

@jjpartridge
Copy link
Collaborator

@mrdsaunders Are there many?

@mrdsaunders
Copy link
Collaborator Author

@jjpartridge there are 325 in the OAM

@tomwrobel
Copy link
Collaborator

325 starts to look like a migration edge case. Examples?

@jjpartridge
Copy link
Collaborator

@jjpartridge
Copy link
Collaborator

jjpartridge commented Feb 11, 2020

Here is an example: https://ora.ox.ac.uk/objects/uuid:9cd3f03f-6dd5-41b4-9d27-e5c3d79e4956 - looks happy in ORA4-REVIEW and ORA4-SYMP

Perhaps failed on pairing or harvest?

@tomwrobel
Copy link
Collaborator

It's not a failure. We have a duplicate here:

https://oxris.ox.ac.uk/viewobject.html?cid=1&id=815179

has two ORA deposited objects:

  • uuid_7b03a960-1377-42f6-a85c-db0ec2961478
  • uuid_9cd3f03f-6dd5-41b4-9d27-e5c3d79e4956

One (the one you linked to) is public and live, the other is not.

Are the other items similarly affected?

@mrdsaunders
Copy link
Collaborator Author

@thomas-wrobel yes that is the common scenario. Here is one with four ORA records, one live the others not:
https://oxris.ox.ac.uk/viewobject.html?cid=1&id=1077177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants