Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file_embargo_end_date to public files if not already set #167

Open
tomwrobel opened this issue Jan 28, 2020 · 2 comments
Open

Add file_embargo_end_date to public files if not already set #167

tomwrobel opened this issue Jan 28, 2020 · 2 comments

Comments

@tomwrobel
Copy link
Collaborator

If a fileset:

  • has a file_made_available_date
  • has a has_public_url
  • has no file_embargo_end_date

Set the file_embargo_end_date to the file_made_available_date in the Sword2 response

@mrdsaunders
Copy link
Collaborator

Toby and I tested this morning and blank embargo release date didn't seem to automatically trigger excessive embargo.

So this won't do any harm, but I'm not sure it will fix the issue. I believe the issue is indefinite date being ingested to all files in SE data even where files have distinct dates (or not date). I'll put in ticket to AB.

@mrdsaunders
Copy link
Collaborator

AB confirms that blank embargo release date should not be ingested to SE as indefinite. So blank dates are not the issue. However date format may play a role here, so he is going to test this by adding date formatting to the crosswalk, we can then test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants