Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected items in "granted county" filter #58

Open
holfordm opened this issue Jul 20, 2023 · 3 comments
Open

unexpected items in "granted county" filter #58

holfordm opened this issue Jul 20, 2023 · 3 comments

Comments

@holfordm
Copy link
Collaborator

This filter includes unidentified places (if not associated with a county) (e.g. Ploufeld) and also regions / places that are not counties (eg. Stafford, archdeanery)

@irv
Copy link
Member

irv commented Jul 25, 2023

I've tidied this up, but there's still a few instances where this is glaringly wrong, on account of a charter mentioning a place that isn't to do with the granting or origin e.g. https://charters-qa.bodleian.ox.ac.uk/catalog/charter_110133

@holfordm
Copy link
Collaborator Author

Thanks - Helen and I need to have a think about exactly what should appear here and what to do about places outside of England and Wales.
One minor point for now is that (after some tidying up) places that have two elements region @type=county are situated in both counties, so they should appear (e.g.) under both Norfolk and Suffolk, and not as "NorfolkSuffolk".

@irv
Copy link
Member

irv commented Jul 26, 2023

Those should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants