Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Threejs cleanup #123

Open
BeebBenjamin opened this issue Nov 4, 2024 · 1 comment
Open

Investigate Threejs cleanup #123

BeebBenjamin opened this issue Nov 4, 2024 · 1 comment
Assignees
@BeebBenjamin
Labels
status: testing PR/MR is being tested on QA type: bug Something isn't working type: enhancement Something needs improving, but isn't a bug
Milestone
November 2024 Rel...

Comments

@BeebBenjamin
Copy link
Contributor

@tdungate noticed a memory leak on Windows when using the plug-in in chrome. This got worse the more he toggled the Threejs canvas on and off. I think, garbage collection isn't disposing of contexts properly, so I think we should handle it in the plug-in and clean up better.
@BeebBenjamin BeebBenjamin added this to the November Release milestone Nov 13, 2024
@BeebBenjamin BeebBenjamin self-assigned this Nov 15, 2024
@BeebBenjamin BeebBenjamin added type: bug Something isn't working type: enhancement Something needs improving, but isn't a bug status: testing PR/MR is being tested on QA labels Nov 15, 2024
@BeebBenjamin
Copy link
Contributor Author

Primary fix in place. Needs performance testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeebBenjamin BeebBenjamin

Labels
status: testing PR/MR is being tested on QA type: bug Something isn't working type: enhancement Something needs improving, but isn't a bug
Projects
None yet
Milestone
November 2024 Release
Development

No branches or pull requests
1 participant
@BeebBenjamin