Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid panic in Reader init (empty2.7z); header.filesInfo is nil. #252

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

wizardishungry
Copy link
Contributor

Found a panic in the Reader's init method for this particular empty 7z found in customer data.

@JadeDickinson
Copy link

try changing the title to
fix: Fixed a panic in init found in empty2.7z

@wizardishungry wizardishungry changed the title Fixed a panic in init found in empty2.7z fix: Avoid panic in Reader init (empty2.7z); header.filesInfo is nil. Aug 27, 2024
@bodgit bodgit added the bug Something isn't working label Aug 29, 2024
@bodgit bodgit self-requested a review August 29, 2024 10:37
@bodgit bodgit merged commit 10d7550 into bodgit:main Aug 29, 2024
4 checks passed
@bodgit
Copy link
Owner

bodgit commented Aug 29, 2024

This fix has been released in v1.5.2. Thank you for the contribution, in particular for adding a test case.

@coveralls
Copy link

Coverage Status

coverage: 75.514%. remained the same
when pulling 4c2c59a on wizardishungry:empty_archive
into 63ddd14 on bodgit:main.

@wizardishungry wizardishungry deleted the empty_archive branch August 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants