-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to block if not all reviewers have approved #853
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use case: When we create a PR, we request review from one or two peers. It would be nice to wait for all of them to approve the PR before merging.
Solution proposal: Add option "maxPendingReviews". Settings that to 0 would require all of the reviewers to either approve or request changes to the PR. Combining it with setting "maxRequestedChanges" to 0 would require every reviewer to approve the PR.
For example
The text was updated successfully, but these errors were encountered: