-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow merging PRs with pending checks #312
Comments
I missed this PR. But yes, I think this is certainly a good option. How do you do the configuration for this feature? |
I added a setting called something like “waitForBlockingChecksOnly” on auto-merge.yml. It’s working well. I’ll repackage it into a PR. |
Maybe we should have something like: blockingChecks: all
blockingChecks: required
blockingChecks: none
|
Has this been added yet? I just found out the hard way that my checks don't complete before the merge takes place and checks weren't validated on a merged branch 👎 |
@erickmendonca could you share code you've wrote? Having same issue that for some PRs some non-required checks may never finish |
|
I concluded, by testing, that the default is probably just the equivalent to |
@rogerluan My experience is that the default is indeed |
@bobvanderlinden Seems to me that with requiredChecks in place, the |
Yup, that's correct, and matches GitHub behavior. However, there's not only "success" and "failure" states - there's also "pending" (or inconclusive, or waiting to be reported etc). If it passes all required checks, and the other checks are NOT failed, it will merge. :) |
hello, is there a description for this |
Seems like it's not documented 😬 |
@Borda @rogerluan If you're referring to #312 (comment), that's hypothetical. It doesn't have an implementation (yet). |
so is there a way-around ho to trigger only if all (or some named ones) pass? |
Hi,
Some repositories might have checks that never complete, e.g. CD checks that need authorization or new CI checks under testing.
I wrote some code to restrict the
blockingChecks
condition to only look for required checks in branch protection rules depending on a setting you can define inauto-merge.yml
.Would this be something we could add to
probot-auto-merge
?The text was updated successfully, but these errors were encountered: