-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use viper for configs #10
Comments
👍 |
Nice! (I don't have time to look at this till the weekend, but I'll look in
|
I have not pushed any code through yet, I will start hacking on this over the weekend (hopefully) |
Oh, cool, sorry - was misreading issue for PR! Do it! :)
|
Just checking in, I think I've got the integration tests working again (I'd screwed up the cloud-init stuff when upgrading go / switching to gom - the code was fine!), so I'm planning to kick the tires on this over the next few days. |
I also did some more digging into viper, and I believe what we are using it for is an overkill since it is much more than a config watcher. However, given it's rather large supporting functions to convert data types and also the fact that you dont have to pass am object around explocitly ( due to it's singleton default behaviour) I believe using viper will simplify lots of the config related code. If I have any more thoughts I will dump them here. |
The advantage of this is it gives us for free a lot of config type conversions, also a very advantageous feature,
is being able to watch the config and dynamically update the current config without restarting the service
The text was updated successfully, but these errors were encountered: