Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viper for configs #10

Open
tsheasha opened this issue Feb 26, 2016 · 7 comments
Open

Use viper for configs #10

tsheasha opened this issue Feb 26, 2016 · 7 comments
Assignees

Comments

@tsheasha
Copy link
Collaborator

The advantage of this is it gives us for free a lot of config type conversions, also a very advantageous feature,
is being able to watch the config and dynamically update the current config without restarting the service

@tsheasha tsheasha self-assigned this Feb 26, 2016
@sarguru
Copy link
Collaborator

sarguru commented Feb 26, 2016

👍

@bobtfish
Copy link
Owner

Nice! (I don't have time to look at this till the weekend, but I'll look in
detail ASAP)
On 26 Feb 2016 12:20, "Sarguru Nathan" [email protected] wrote:

[image: 👍]


Reply to this email directly or view it on GitHub
#10 (comment).

@tsheasha
Copy link
Collaborator Author

I have not pushed any code through yet, I will start hacking on this over the weekend (hopefully)

@bobtfish
Copy link
Owner

Oh, cool, sorry - was misreading issue for PR! Do it! :)
On 26 Feb 2016 14:00, "T Sheasha" [email protected] wrote:

I have not pushed any code through yet, I will start hacking on this over
the weekend (hopefully)


Reply to this email directly or view it on GitHub
#10 (comment).

@bobtfish
Copy link
Owner

bobtfish commented Mar 5, 2016

@bobtfish
Copy link
Owner

Just checking in, I think I've got the integration tests working again (I'd screwed up the cloud-init stuff when upgrading go / switching to gom - the code was fine!), so I'm planning to kick the tires on this over the next few days.

@tsheasha
Copy link
Collaborator Author

I also did some more digging into viper, and I believe what we are using it for is an overkill since it is much more than a config watcher. However, given it's rather large supporting functions to convert data types and also the fact that you dont have to pass am object around explocitly ( due to it's singleton default behaviour) I believe using viper will simplify lots of the config related code.

If I have any more thoughts I will dump them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants