Add fixboard to firmware reflash #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamD2021
force-pushed
the
add_fixboard
branch
from
3bc5de8 to
4cd5e98
Compare
SalDaniele
reviewed
Dec 4, 2024
| @@ -127,6 +139,15 @@ def reflash_ipu(self) -> None: | |||
| else: | |||
| self.logger.info("Skipping flash_spi_image") | |||
|
|
|||
| self.logger.info("Step 5: apply_fixboard") | |||
| if self.should_run("apply_fixboard"): | |||
| should_fixboard = self.fixboard_is_needed() | |||
There was a problem hiding this comment.
Why make fixboard_is_needed() return an optional bool?
In my mind this could be simplified a bit.
if self.fixboard_is_needed():
self.apply_fixboard()
else:
# assume fixboard has already been applied, or the user does not want to apply this (though I'm not sure if the user has a knob to tell fwup to only run a subset of the steps anyways right now).
If we hit an exception when trying to determine if we should apply fixboard, something is wrong and we should bail out with an error code.
|
|
||
| def fixboard_is_needed(self) -> Optional[bool]: | ||
| full_address = f"root@{self.imc_address}" | ||
| try: |
There was a problem hiding this comment.
Do we expect this to fail?
This will be useful for traversing through the server for fixboard pre-built board config binaries
We often want to avoid host checking and such so it would be nice to have a function that abstract all those flags and runs the command on the remote host
apply_fixboard
SamD2021
force-pushed
the
add_fixboard
branch
from
4cd5e98 to
7d210e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need unique MAC addresses for each IPU, and to make that happen, we use pre-built fixboard images that need to be flashed after the firmware is applied. To support this, I added these pre-built images to our ARM server and wrote functions to interact with them, making it easier to add unique MAC addresses. I also created functions to check if the fixboard process needs to be applied and handle the flashing if it does.
On top of that, I added a new ssh_run function to simplify running commands on remote hosts, since that’s a pretty common task and it made sense to make it easier and more consistent.