Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source deployed as .ts - please deploy as .d.ts #50

Open
davejlin opened this issue Aug 16, 2019 · 0 comments
Open

Source deployed as .ts - please deploy as .d.ts #50

davejlin opened this issue Aug 16, 2019 · 0 comments

Comments

@davejlin
Copy link

Current source is deployed as .ts files.

However, due to module resolution as a dependency, this causes compilation errors for us due to more stringent options.

Please consider deploying in library format (.d.ts) so that we can skip these files during compilation.

This can be done by specifying "declaration": true, in your tsconfig.json file.

Example of compilation errors:

> [email protected] lint /Users/xxxxxx/Documents/Projects/ts-joynr
> tslint -c tslint.json -p tsconfig.test.json

node_modules/joynr/joynr/util/UtilInternal.ts:27:22 - error TS2339: Property 'hasOwnProperty' does not exist on type 'U'.

27             if (from.hasOwnProperty(key)) {
                        ~~~~~~~~~~~~~~
node_modules/joynr/joynr/util/UtilInternal.ts:90:31 - error TS2345: Argument of type 'any' is not assignable to parameter of type 'never'.

90         transformedArray.push(transformFunction(value, i));
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 2 errors.

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build: `npm run lint && tsc  -p tsconfig.json`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/xxxxxx/.npm/_logs/2019-08-16T20_57_34_914Z-debug.log
LCHI605847:ts-joynr xxxxxx$ 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant