Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better code structure #31

Open
aersam opened this issue May 24, 2023 · 2 comments
Open

Better code structure #31

aersam opened this issue May 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@aersam
Copy link
Contributor

aersam commented May 24, 2023

  • SQL Execution is split between dataframe and endpoint, sometimes diff is a bit weird
  • Do we really need groupby/joins/sortby? If yes: test and document
@dominikpeter
Copy link
Member

We need sortby. Get the top n sorted by is a common use case. We need it for the recommender for sure.
Groupby and joins could be handled through the SQL Endpoint. Probably better to do there.

@aersam
Copy link
Contributor Author

aersam commented May 24, 2023

ok, I'll remove groupby and join then. and might do some test for sortby

@aersam aersam mentioned this issue May 24, 2023
Merged
@dominikpeter dominikpeter added the enhancement New feature or request label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aersam @dominikpeter