Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3uParser.parse does not need to be async #1

Open
julemand101 opened this issue Apr 28, 2020 · 2 comments
Open

M3uParser.parse does not need to be async #1

julemand101 opened this issue Apr 28, 2020 · 2 comments

Comments

@julemand101
Copy link

It seems like a weird design choice to make the parse method async since it does not contain any IO operations or other async stuff.

Could you remove the async or are there some reason for it that I don't see?

@timekone
Copy link

I think this would be a welcome change. But unfortunately, removing async will create a breaking change.

@julemand101
Copy link
Author

Yeah, but I don't think it is going to be a too big of a breaking change since it can easily be fixed by removing an await keyword. It would be a lot worse if the opposite was going to happen where we added the need of await.

But I would suggest doing this in an update where other major stuff are going to be introduced or refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants