Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go To declaration with PHPDoc @see works partly #3111

Open
dmitrach opened this issue Nov 2, 2024 · 2 comments
Open

Go To declaration with PHPDoc @see works partly #3111

dmitrach opened this issue Nov 2, 2024 · 2 comments

Comments

@dmitrach
Copy link

dmitrach commented Nov 2, 2024

Describe the bug
Our project has some @see tags. Most of developers use PHPStorm and they use the next syntax: @see AnotherClass::method() or @see AnotherClass::$privateProperty.
This way doesn't work for me, but works this way: @see Full\Path\To\AnotherClass::method() or @see Full\Path\To\AnotherClass::$privateProperty.

To Reproduce
Use different classes.

It doesn't work if you try to go to the declaration or try to get the method description.

namespace MyApp;

class A
{
   public function m1() {}
}

class B
{
   /**
    * @see A::m1()
    */
   public function m2() {}
}

But it works.

namespace MyApp;

class A
{
   public function m1() {}
}

class B
{
   /**
    * @see MyApp\A::m1()
    */
   public function m2() {}
}

Expected behavior
Both options works.

Screenshots

изображение

Platform and version
PHP Intelephense v1.12.6

VS Code Version: 1.94.2
Node.js: 20.16.0
OS: Linux x64 6.8.0-48-generic (Ubuntu 22.04)

@demoneno4ec
Copy link

is still being reproduced today

@bmewburn
Copy link
Owner

The reference suggests that it should be a FQSEN, ie fully qualified. https://docs.phpdoc.org/guide/references/phpdoc/tags/see.html#see

We'll see if this requirement can be relaxed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants