forked from eduridden/moodle-theme_elegance
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL support (Initial suggestions) #150
Comments
Outcomes of applying the above suggested fixes can be experienced on the following link: |
Hi Bas, |
Hi Nadav, They look great and result looks real nice too.. So please do send that pull request and I'll add and test it myself too! Thanks so much. |
Groovy, I will send a PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Bas,
I am currently involved in a project to extract several accessibility issues from an old v2.7 Elegance theme the Israeli Open University developed, into your new 2.9 version. (I will send PR when it is done) but, for this process to start we needed to fix some basic RTL issues. not all.
So here is some suggested code I wish to send as pull request but need for you to review it as I am not sure if it is implemented they way you plan Elegance will be using LESS from now on.
Here is a link to a quick collection of un sorted fixes from the project's gitlab repo:
http://gitlab.accessibility.bitnamiapp.com/moodle-accessibility/moodle/commit/fb34ae5c0efb61ca114ac106b28a66c675cbe4a2
My general thoughts are:
What do you think?
The text was updated successfully, but these errors were encountered: