Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable school deletion and add disable feature instead #116

Closed
AmonDeShir opened this issue Nov 11, 2024 · 0 comments · Fixed by #125
Closed

Disable school deletion and add disable feature instead #116

AmonDeShir opened this issue Nov 11, 2024 · 0 comments · Fixed by #125
Assignees
@AmonDeShir
Milestone
Demo v2

Comments

@AmonDeShir
Copy link
Collaborator

Currently, deleting a school results in the removal of all users assigned to it. Setting the school as nullable is not possible due to the current ranking system implementation.

We should disable the option to delete a school and instead implement a feature that allows schools to be "disabled." Disabled schools should not appear during user account creation or editing. Disabled schools should still be visible in rankings and user lists.
@AmonDeShir AmonDeShir added this to the Demo v2 milestone Nov 11, 2024
@AmonDeShir AmonDeShir self-assigned this Dec 8, 2024
@AmonDeShir AmonDeShir linked a pull request Dec 8, 2024 that will close this issue
#116 - Add school disabling #125
Merged
@AmonDeShir AmonDeShir mentioned this issue Dec 8, 2024
Merged
AmonDeShir added a commit that referenced this issue Dec 9, 2024
@AmonDeShir
#116 - Add school disabling (#125)
177a04a 
* add is_disabled tu schools table

* fix code style

* remove unused routes

* add disable school route

* update school resource

* fix code style

* implement school enabling

* hide disabled schools in select school input

* fix user test

* create school for admins

* fix code style

* fix code style

* fix test

* remove randomness from school test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmonDeShir AmonDeShir

Labels
None yet
Projects
None yet
Milestone
Demo v2
Development

Successfully merging a pull request may close this issue.

#116 - Add school disabling blumilksoftware/interns2024b
1 participant
@AmonDeShir