This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
#89 - unit tests #104
Open
#89 - unit tests #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
| { | ||
| public function createApplication(): Application | ||
| { | ||
| $app = require __DIR__ . "/../bootstrap/app.php"; |
There was a problem hiding this comment.
You don't need bootstrapping file. You can bootstrap application from Blumilk\Meetup\Core\MeetupApplication class.
There was a problem hiding this comment.
Then I get the RuntimeException "A facade root has not been set".
There was a problem hiding this comment.
What facade do you want to use and where?
There was a problem hiding this comment.
Nowhere, I just create object of MeetupApplication class and use getApplication method.
There was a problem hiding this comment.
I still don't get it. Behat tests were working fine with this packaged app approach. Please take care about removing /bootstrap/app.php file and wire application in your test cases bootstrap.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created basic tests. Hence I also fix organization profile routes and change admin invitation receiver.