From 09f0a4879e4394eb186747322428580ceb384ce5 Mon Sep 17 00:00:00 2001 From: Anna-Sokolowska Date: Fri, 22 Apr 2022 14:11:10 +0200 Subject: [PATCH] #7 - change unnecessary outline scenarios --- .../adding_user_to_admin_panel.feature | 29 +++++++------------ .../admin_panel/creating_new_admin.feature | 11 +++---- features/admin_panel/meetup/delete.feature | 7 ++--- features/admin_panel/meetup/show.feature | 7 ++--- features/admin_panel/meetup/update.feature | 14 +++------ .../admin_panel/organization/delete.feature | 7 ++--- .../admin_panel/organization/show.feature | 7 ++--- .../admin_panel/organization/update.feature | 14 +++------ features/admin_panel/speakers/delete.feature | 7 ++--- features/admin_panel/speakers/show.feature | 7 ++--- features/admin_panel/speakers/update.feature | 14 +++------ features/meetup/delete.feature | 14 +++------ features/meetup/show.feature | 7 ++--- features/meetup/update.feature | 14 +++------ 14 files changed, 48 insertions(+), 111 deletions(-) diff --git a/features/admin_panel/adding_user_to_admin_panel.feature b/features/admin_panel/adding_user_to_admin_panel.feature index d173b302..d70b75d6 100644 --- a/features/admin_panel/adding_user_to_admin_panel.feature +++ b/features/admin_panel/adding_user_to_admin_panel.feature @@ -4,15 +4,12 @@ Feature: Adding a user to admin panel Given the administrator is logged in And the administrator is on the page with invitation form - Scenario Outline: Successfully send invitation to unregistered user + Scenario Successfully send invitation to unregistered user Given the invited user doesn't have an account - When the administrator fills in "email" with "" + When the administrator fills in "email" with "firstuser@example.com" And the administrator sends the form Then the administrator should see "Successfully send invitation" - And the invited user should get an invitation link on "" - Examples: - | email | - | firstuser@example.com | + And the invited user should get an invitation link on "firstuser@example.com" Scenario: An administrator fills in invited user email field with invalid email When the administrator fills in "email" with "wrongemail@" @@ -23,22 +20,16 @@ Feature: Adding a user to admin panel When the administrator sends the form Then the administrator should see "Email field is required" - Scenario Outline: The invited user is already an administrator - Given the user with "" email address is already an administrator - When the administrator fills in "email" with "" + Scenario: The invited user is already an administrator + Given the user with "existingadmin@example.com" email address is already an administrator + When the administrator fills in "email" with "existingadmin@example.com" And the administrator sends the form Then the administrator should see the message "This user is already an administrator" - Examples: - | email | - | existingadmin@example.com | - Scenario Outline: Successfully send invitation to already registered user - Given There is a user with "" email address + Scenario: Successfully send invitation to already registered user + Given There is a user with "firstuser@example.com" email address And the invited user is not an administrator yet - When the administrator fills in "email" with "" + When the administrator fills in "email" with "firstuser@example.com" And the administrator sends the form Then the administrator should see "Successfully send invitation" - And invited user should get an invitation link on "" - Examples: - | email | - | firstuser@example.com | + And invited user should get an invitation link on "firstuser@example.com" diff --git a/features/admin_panel/creating_new_admin.feature b/features/admin_panel/creating_new_admin.feature index 33dbec22..0e4ca18e 100644 --- a/features/admin_panel/creating_new_admin.feature +++ b/features/admin_panel/creating_new_admin.feature @@ -7,16 +7,13 @@ Feature: Creating a admin user Scenario: The invited user already have account Given the invited user is on the authentication route by invitation link - When the invited user logs in as "" + When the invited user logs in as "user@example.com " Then the invited user becomes admin user - Scenario Outline: Successfully created an account + Scenario: Successfully created an account Given the invited user is on the authentication route by invitation link - When the invited user registers with "" email address - Then new administrator with email "" should be created - Examples: - | email | - | user@example.com | + When the invited user registers with "user@example.com " email address + Then new administrator with email "user@example.com " should be created Scenario: The invitation has expired Given the invitation was send more than 7 days ago diff --git a/features/admin_panel/meetup/delete.feature b/features/admin_panel/meetup/delete.feature index ae8c8774..98b7986d 100644 --- a/features/admin_panel/meetup/delete.feature +++ b/features/admin_panel/meetup/delete.feature @@ -6,10 +6,7 @@ Feature: Deleting a meetup | 1 | example meetup | 2023-01-01 10:10:10 | example place | pl | And the administrator is logged in - Scenario Outline: Successfully deleting a meetup - Given the administrator is on the deleting meetup page with meetup id equals "" + Scenario: Successfully deleting a meetup + Given the administrator is on the deleting meetup page with meetup id equals "1" When the administrator clicks on the delete meetup button Then the administrator should see the message "Meetup successfully deleted" - Examples: - | id | - | 1 | diff --git a/features/admin_panel/meetup/show.feature b/features/admin_panel/meetup/show.feature index f5f992db..4c016ea2 100644 --- a/features/admin_panel/meetup/show.feature +++ b/features/admin_panel/meetup/show.feature @@ -16,9 +16,6 @@ Feature: Showing a meetup | id | title | date | place | language | | 1 | example meetup | 2023-01-01 10:10:10 | example place | pl | - Scenario Outline: Attempt to show a meetup which does not exist - When the administrator get to the show meetup page with id equals "" + Scenario: Attempt to show a meetup which does not exist + When the administrator get to the show meetup page with id equals "999" Then the administrator should see the message "Page not found" - Examples: - | id | - | 999 | diff --git a/features/admin_panel/meetup/update.feature b/features/admin_panel/meetup/update.feature index 03260b4a..387c9055 100644 --- a/features/admin_panel/meetup/update.feature +++ b/features/admin_panel/meetup/update.feature @@ -46,20 +46,14 @@ Feature: Updating a meetup | id | language | | 1 | en | - Scenario Outline: Attempt to update a meetup without credentials - Given the administrator is on the update meetup page with id equals "" + Scenario: Attempt to update a meetup without credentials + Given the administrator is on the update meetup page with id equals "1" When the administrator sends the form Then the administrator should see the message "Title field is required" And the administrator should see the message "Date field are required" And the administrator should see the message "Place field are required" And the administrator should see the message "Language field are required" - Examples: - | id | - | 1 | - Scenario Outline: Attempt to update a meetup which does not exist - When the administrator get to the update meetup page with id equals "" + Scenario: Attempt to update a meetup which does not exist + When the administrator get to the update meetup page with id equals "999" Then the administrator should see the message "Page not found" - Examples: - | id | - | 999 | diff --git a/features/admin_panel/organization/delete.feature b/features/admin_panel/organization/delete.feature index 506ef4f0..dc62281f 100644 --- a/features/admin_panel/organization/delete.feature +++ b/features/admin_panel/organization/delete.feature @@ -6,10 +6,7 @@ Feature: Deleting an organization | 1 | example organization | existing organization | And the administrator is logged in - Scenario Outline: Successfully deleting an organization - Given the administrator is on the deleting organization page with organization id "" + Scenario: Successfully deleting an organization + Given the administrator is on the deleting organization page with organization id "1" When the administrator clicks on the delete organization button Then the administrator should see the message "Organization successfully deleted" - Examples: - | id | - | 1 | diff --git a/features/admin_panel/organization/show.feature b/features/admin_panel/organization/show.feature index e8b7fd4f..ede26764 100644 --- a/features/admin_panel/organization/show.feature +++ b/features/admin_panel/organization/show.feature @@ -14,9 +14,6 @@ Feature: Showing an organization | id | name | description | | 1 | example organization | existing organization | - Scenario Outline: Attempt to show an organization which does not exist - When the administrator get to the show organization page with id equals "" + Scenario: Attempt to show an organization which does not exist + When the administrator get to the show organization page with id equals "999" Then the administrator should see the message "Page not found" - Examples: - | id | - | 999 | diff --git a/features/admin_panel/organization/update.feature b/features/admin_panel/organization/update.feature index 52c834f2..76d95a9e 100644 --- a/features/admin_panel/organization/update.feature +++ b/features/admin_panel/organization/update.feature @@ -16,17 +16,11 @@ Feature: Updating an organization | id | name | | 1 | updated organization | - Scenario Outline: Attempt to update an organization without credentials - Given the administrator is on the update organization page with id equals "" + Scenario: Attempt to update an organization without credentials + Given the administrator is on the update organization page with id equals "1" When the administrator sends the form Then the administrator should see the message "Name field is required" - Examples: - | id | - | 1 | - Scenario Outline: Attempt to update an organization which does not exist - When the administrator get to the update organization page with id equals "" + Scenario: Attempt to update an organization which does not exist + When the administrator get to the update organization page with id equals "999" Then the administrator should see the message "Page not found" - Examples: - | id | - | 999 | diff --git a/features/admin_panel/speakers/delete.feature b/features/admin_panel/speakers/delete.feature index 870eba2b..795b88a0 100644 --- a/features/admin_panel/speakers/delete.feature +++ b/features/admin_panel/speakers/delete.feature @@ -6,10 +6,7 @@ Feature: Deleting a speaker | 1 | example speaker | existing speaker | And the administrator is logged in - Scenario Outline: Successfully deleting a speaker - Given the administrator is on the deleting speaker page with meetup id equals "" + Scenario: Successfully deleting a speaker + Given the administrator is on the deleting speaker page with meetup id equals "1" When the administrator clicks on the delete speaker button Then the administrator should see the message "Speaker successfully deleted" - Examples: - | id | - | 1 | diff --git a/features/admin_panel/speakers/show.feature b/features/admin_panel/speakers/show.feature index 056afa2c..fe7735e8 100644 --- a/features/admin_panel/speakers/show.feature +++ b/features/admin_panel/speakers/show.feature @@ -14,9 +14,6 @@ Feature: Showing a speaker | id | name | description | | 1 | example speaker | existing speaker | - Scenario Outline: Attempt to show a speaker which does not exist - When the administrator get to the show speaker page with id equals "" + Scenario: Attempt to show a speaker which does not exist + When the administrator get to the show speaker page with id equals "999" Then the administrator should see the message "Page not found" - Examples: - | id | - | 999 | diff --git a/features/admin_panel/speakers/update.feature b/features/admin_panel/speakers/update.feature index 08becb87..cfc7f2b3 100644 --- a/features/admin_panel/speakers/update.feature +++ b/features/admin_panel/speakers/update.feature @@ -16,17 +16,11 @@ Feature: Updating a speaker | id | name | | 1 | updated speaker | - Scenario Outline: Attempt to update a speaker without credentials - Given the administrator is on the update speaker page with id equals "" + Scenario: Attempt to update a speaker without credentials + Given the administrator is on the update speaker page with id equals "1" When the administrator sends the form Then the administrator should see the message "Name field is required" - Examples: - | id | - | 1 | - Scenario Outline: Attempt to update a speaker which does not exist - When the administrator get to the update speaker page with id equals "" + Scenario: Attempt to update a speaker which does not exist + When the administrator get to the update speaker page with id equals "999" Then the administrator should see the message "Page not found" - Examples: - | id | - | 999 | diff --git a/features/meetup/delete.feature b/features/meetup/delete.feature index 4f42ec8e..42bb0035 100644 --- a/features/meetup/delete.feature +++ b/features/meetup/delete.feature @@ -8,17 +8,11 @@ Feature: Deleting a meetup And the user with id equals "1" is logged in And the user is not an administrator - Scenario Outline: Deleting a meetup as an organizer - Given the user is on the meetup page with organizer id equals "" + Scenario: Deleting a meetup as an organizer + Given the user is on the meetup page with organizer id equals "1" When the user clicks on the delete meetup button Then the user should see message "Meetup successfully deleted" - Examples: - | id | - | 1 | - Scenario Outline: Attempt to delete a meetup not as an organizer - Given the user is on the meetup page with organizer id equals "" + Scenario: Attempt to delete a meetup not as an organizer + Given the user is on the meetup page with organizer id equals "2" Then the user should see the message "You are not allowed to access this page" - Examples: - | id | - | 2 | diff --git a/features/meetup/show.feature b/features/meetup/show.feature index 0cc6e838..31efcd50 100644 --- a/features/meetup/show.feature +++ b/features/meetup/show.feature @@ -22,9 +22,6 @@ Feature: Showing a meetup | 1 | 1 | my meetup | 2023-01-01 10:10:10 | place | pl | | 2 | 2 | foreign meetup | 2023-01-01 10:10:10 | place | pl | - Scenario Outline: Attempt to show a meetup which does not exist - When the user in on the show meetup page with id equals "" + Scenario: Attempt to show a meetup which does not exist + When the user in on the show meetup page with id equals "999" Then the user should see the message "Page not found" - Examples: - | id | - | 999 | diff --git a/features/meetup/update.feature b/features/meetup/update.feature index f02caf7a..9580bdcf 100644 --- a/features/meetup/update.feature +++ b/features/meetup/update.feature @@ -48,20 +48,14 @@ Feature: Updating a meetup | id | language | | 1 | en | - Scenario Outline: Attempt to update a meetup without credentials - Given the user is on the update meetup page with id equals "" + Scenario: Attempt to update a meetup without credentials + Given the user is on the update meetup page with id equals "1" When the user sends the form Then the user should see the message "Title field is required" And the user should see the message "Date field are required" And the user should see the message "Place field are required" And the user should see the message "Language field are required" - Examples: - | id | - | 1 | - Scenario Outline: Updating meetup as not an organizer - When The user is on the update meetup page with organizer id equals "" + Scenario: Updating meetup as not an organizer + When The user is on the update meetup page with organizer id equals "2" Then The user should see "You are not allowed to do this" - Examples: - | id | - | 2 |