#22 - Add permission handling #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilpiech97
requested changes
Jun 13, 2024
app/Services/PermissionService.php
Outdated
|
|
||
| if ($response->json("installations") !== null) { | ||
| foreach ($response->json("installations") as $installation) { | ||
| if ($installation["app_id"] === intval(env("GITHUB_APP_ID"))) { |
There was a problem hiding this comment.
Lets move env value into config, config can be cached.
app/Services/PermissionService.php
Outdated
| { | ||
| public function checkPermissions(): bool | ||
| { | ||
| $permissions_given = false; |
There was a problem hiding this comment.
Suggested change
| $permissions_given = false; | |
| $permissionsGiven = false; |
app/Services/PermissionService.php
Outdated
|
|
||
| class PermissionService | ||
| { | ||
| public function checkPermissions(): bool |
There was a problem hiding this comment.
Suggested change
| public function checkPermissions(): bool | |
| public function checkGitHubAppInstallation(): bool |
More described what that function do.
kamilpiech97
requested changes
Jun 13, 2024
| @@ -21,5 +21,6 @@ | |||
| "client_id" => env("GITHUB_CLIENT_ID"), | |||
| "client_secret" => env("GITHUB_CLIENT_SECRET"), | |||
| "redirect" => env("GITHUB_REDIRECT_URL"), | |||
| "app_id" => 918356, | |||
There was a problem hiding this comment.
Suggested change
| "app_id" => 918356, | |
| "app_id" => env("GITHUB_APP_ID"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #22
Added permission service that checks if user gave permissions for the application
Added middleware that can be used on routes that need permissions