Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ports parameters #6

Open
krzysztofrewak opened this issue Nov 17, 2023 · 0 comments
Open

Remove redundant ports parameters #6

krzysztofrewak opened this issue Nov 17, 2023 · 0 comments

Comments

@krzysztofrewak
Copy link
Member

krzysztofrewak commented Nov 17, 2023

As we discussed earlier, I think this is an overkill:

bash <(curl -s https://raw.githubusercontent.com/blumilksoftware/boilerplate/init.sh) <app-name> [app-namespace] [branch-name] [app-host-port] [db-host-port] [mailpit-dashboard-port] [redis-host-port]

I would prefer to provide only app-host-port and then next ports would be by default set up to app-host-port + 1, app-host-port + 2 and so on. Current solution should stay if anyone would like to set up some specific ports as well.

Btw. hosts are changed in .env.example, but not in docker-compose.yml and readme.md. It should be changed there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant